Add 3422610-4.patch to betterlogin to fix Redirect loop when accessing a forbidden route with 'user' query parameter

Open on Drupal.org →

Created on 27 February 2024, about 1 year ago

Updated 14 April 2024, about 1 year ago

Problem/Motivation

When anonymously accessing a forbidden route while having "user" query parameter, the response will be a redirect to the originally requested URL, and therefore, the user will encounter an infinite redirect loop.

This is caused by betterlogin module and there's an existing patch that fixes the issue.

ERR_TOO_MANY_REDIRECTS

Steps to reproduce

With fresh Varbase installation
Anonymously navigate to /admin?user=x
Observe the redirect loop

Proposed resolution

Change drupal/betterlogin to 2.0.1 in the composer.json file.
Add the patch for 🐛 Fix Redirect loop when accessing a forbidden route with 'user' query parameter Fixed

Remaining tasks

✅ File an issue about this project
✅ Addition/Change/Update/Fix to this project
✅ Testing to ensure no regression
➖ Automated unit/functional testing coverage
➖ Developer Documentation support on feature change/addition
➖ User Guide Documentation support on feature change/addition
➖ UX/UI designer responsibilities
➖ Accessibility and Readability
✅ Code review from 1 Varbase core team member
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Update Release Notes and Update Helper on new feature change/addition
❌ Release varbase-9.1.2 → , varbase_core-9.1.27 →

Varbase update type

✅ No Update
➖ Optional Update
➖ Forced Update
➖ Forced Update if Unchanged

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

Issue #3424034 → by Redwan Jamous → : Added 3422610-4.patch to Better Login to fix Redirect loop when accessing a forbidden route with 'user' query parameter

🐛 Bug report

Status

Fixed

Version

9.1

Component

Code

Created by

Live updates comments and jobs are added and updated live.

varbase-9.1.2

varbase_core-9.1.27

Sign in to follow issues

Merge Requests

!39Add 3422610-4.patch to betterlogin to fix Redirect loop when accessing a forbidden route with 'user' query parameter
Open
Unnamed author
updated about 1 year ago

Comments & Activities

Issue created by @RedwanJamous
Merge request !39Issue #3424034: Apply 3422610-4.patch to betterlogin module to fix a redirect loop → (Open) created by Unnamed author
Comment about 1 year ago →
RedwanJamous
Redwan Jamous → changed the visibility of the branch 3424034-add-3422610-4.patch-to to hidden.
Issue was unassigned.
Status changed to Needs review about 1 year ago11:42am 27 February 2024
Comment about 1 year ago →
RedwanJamous
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
Tested
Before the patch:
Going to "/admin?user=2" for example will hit ERR_TOO_MANY_REDIRECTS

After applying the patch:
the site will redirect to "/user/login?destination=user"
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
Status changed to Fixed about 1 year ago9:31am 4 March 2024
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
✅ Released varbase_core-9.1.27 →
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment about 1 year ago →
🇯🇴Jordan Rajab Natshah Jordan
✅ Released varbase-9.1.2 →

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024