- Issue created by @carlxjs
- Status changed to RTBC
3 months ago 8:12pm 16 August 2024 - 🇨🇦Canada joseph.olstad
Thank you @sandipta !
This patch is correct.With that said , I'm still learning/evaluating how this module works (or not).
- Status changed to Active
3 months ago 10:15pm 16 August 2024 - 🇨🇦Canada joseph.olstad
Ok patch #2 doesn't do the job, but I do have a new patch that does.
- Status changed to RTBC
3 months ago 2:26pm 19 August 2024 - Merge request !1Issue #3423993 by joseph.olstad, sandipta: Js file name is wrong and... → (Open) created by joseph.olstad
- 🇨🇦Canada joseph.olstad
New patch, this covers all normal use cases, only kills session when the browser is closed
- 🇦🇺Australia imclean Tasmania
Another option would be to use the visibilitychange event which works more reliably on mobile platforms than beforeunload.
- Status changed to Needs review
3 months ago 2:18pm 21 August 2024 - 🇨🇦Canada joseph.olstad
See my comments #9. This isn't perfect so we're likely going to uninstall this module. With that said, by all means continue working on this. The security constraints of modern browsers hasn't yet allowed an api connect between the actual close button and a js event that directly corresponds to it. The js unload event is too broad. It was a nice idea in theory but in practice just doesn't work as we had hoped. With that said, this idea could be useful for other use cases that I'm currently not working on.