Cache tags added to build are overwritten by Layout Builder

Created on 26 February 2024, about 1 year ago

Updated 3 May 2024, 11 months ago

Problem/Motivation

Cache tags for the selected styles are added to the block build array in BlockComponentRenderArraySubscriber, but Layout Builder overwrites them in SectionComponent::toRenderArray().

Steps to reproduce

Set a breakpoint in SectionComponent::toRenderArray() on return $output and inspect $output['#cache']['tags']. The config:layout_builder_styles.style tag isn't in the array because they are overwritten by the line $event->getCacheableMetadata()->applyTo($output);.

Proposed resolution

Add the tags to $event->getCacheableMetadata().

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇺🇸United States karlshea Minneapolis 🇺🇸

Live updates comments and jobs are added and updated live.

Merge Requests

!22Cache tags added to build are overwritten by Layout Builder
Open
🇺🇸United States karlshea
updated about 1 year ago

Comments & Activities

Issue created by @karlshea
Merge request !22Fix cache tags in SectionComponentBuildRenderArrayEvent subscriber → (Open) created by karlshea
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 5.3 & MySQL 5.5
last update about 1 year ago
Composer error. Unable to continue.
Comment about 1 year ago →
🇺🇸United States karlshea Minneapolis 🇺🇸
Status changed to Needs review about 1 year ago9:33pm 26 February 2024
Comment about 1 year ago →
🇺🇸United States karlshea Minneapolis 🇺🇸
Status changed to RTBC 11 months ago3:42pm 3 May 2024
Comment 11 months ago →
🇺🇸United States mark_fullmer Tucson
Good find! This logic change makes sense to me.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024