Validate that every config entity listed in the config.actions section of recipe.yml belongs to an extension that is installed, or will be by the recipe or one of its dependencies

narendraR → changed the visibility of the branch 3423526-pp-1-validate-that to hidden.

There are basically 2 things which needs to be validated.

• config:actions

  config:
    actions:
      config_test.dynamic.recipe:
        ensure_exists:
          label: 'Created by recipe'
        setProtectedProperty: 'Set by recipe'

  config_test should be either already present or is defined in recipes. And I think if action start with core, we don't have to do anything. eg in case of core.entity_form_display.node.article.default

• config:import

  config:
    import:
      config_test: '*'

  config_test should be either already present or is defined in recipes.

Not sure if this issue should handle both as suggested in MR comment, added IS update tag for that.

Filled out the issue summary with some more info. Hopefully that's helpful!

srishtiiee → changed the visibility of the branch 3423526-validate_config_actions_entities to hidden.

srishtiiee → changed the visibility of the branch validate_config_actions to hidden.

AFAICT this could have prevented #3427118: Config error when a module installs a text format → 😄 @srishtiiee, can you confirm? 😊🙏

The logic looks great! 🤩 Zero remarks 👍

My only concern: we're not explicitly testing all of the code paths we're adding. I'd feel more comfortable RTBC'ing this if all the scenarios I listed on the MR would be tested.

This is a great start, and I think the logic is sound, but the code could use some tightening up. :)

I think this looks pretty good and tests what it needs to. Since I did some refactoring (nothing major - the core logic is intact but I tried to clarify what we're doing here), I think it's back to Wim for final review.

It's been nearly two weeks, and no movement here. I think it's okay for Alex to review this.

Committed and pushed 2d6152b4e59 to 11.x and a55df2173d4 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.