Creation of dynamic property is deprecated

Created on 23 February 2024, 9 months ago

Updated 18 June 2024, 5 months ago

Problem/Motivation

Drupal 10 PHP 8.3
Deprecated function : Creation of dynamic property Drupal\role_based_theme_switcher\Theme\RoleNegotiator::$theme is deprecated in Drupal\role_based_theme_switcher\Theme\RoleNegotiator->applies() (/var/www/platform/web/modules/contrib/role_based_theme_switcher/src/Theme/RoleNegotiator.php ligne 81)

Switching from a theme to another doesn't work.

Steps to reproduce

Enable the module role_based_theme_switcher

Proposed resolution

To fix the error, modify the class and declare all properties explicitly.
Instead of dynamically assigning properties in the constructor (variable $theme in the case), declare it in the class definition.

🐛 Bug report

Status

Needs review

Version

3.0

Component

Code

Created by

🇧🇪Belgium xdequinze Brussels

Live updates comments and jobs are added and updated live.

Merge Requests

!3Creation of dynamic property is deprecated
Open
🇮🇳India samit.310@gmail.com
updated 5 months ago

Comments & Activities

Issue created by @xdequinze
Comment 9 months ago →
🇧🇪Belgium xdequinze Brussels
Comment 9 months ago →
🇧🇪Belgium xdequinze Brussels
Here is a patch.
Comment 7 months ago →
🇮🇳India sourabhutani
Patch in #3 is working for me and fixed deprecation warning. Thanks
Comment 5 months ago →
🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
Merge request !33423481: fix dynamic property deprication error → (Open) created by samit.310@gmail.com
Issue was unassigned.
Status changed to Needs review 5 months ago7:54am 18 June 2024
Comment 5 months ago →
🇮🇳India samit.310@gmail.com

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024