Read more button needs to styled.

Created on 23 February 2024, 10 months ago
Updated 26 April 2024, 8 months ago

🐛 Bug report
Status

Closed: works as designed

Version

2.0

Component

Code

Created by

🇮🇳India alok_singh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alok_singh
  • Pipeline finished with Success
    10 months ago
    #102068
  • Status changed to Needs review 10 months ago
  • Status changed to RTBC 10 months ago
  • Verified MR3 on 9.5.x, the Read more button is styled. Added screenshots for reference, RTBC++

  • 🇬🇧United Kingdom the_g_bomb

    Thank you for the report and the MR, I will review asap.

    • the_g_bomb committed 62444d51 on 8.x-2.x
      Issue #3423374 by alok_singh, Tanuja Bohra, the_g_bomb: Read more button...
  • Status changed to Closed: works as designed 10 months ago
  • 🇬🇧United Kingdom the_g_bomb

    Having had a good hunt through the code, I couldn't see any styling for the Readmore links, which I did find strange.

    I even returned to the source files to see what was there and found nothing still.

    I have had a look in the Wayback Machine to see if I could see how they were styled in the original Boldy WordPress theme, only slightly more styling, but basically, it is just some padding.

    I did notice that the "Read More" links have a double right arrow, which I will add to the links, but I certainly don't think there was a button intended.

    While I like the addition, I think I'll keep the original intended styling.

    Secondly, the CSS button style you have added in the MR is not technically in keeping with the buttons elsewhere in the theme. I would recommend 1 of 2 things.
    1. Use the technique that is used to style up the #shareLinks. i.e. there is a border with rounded edges and a gradient background image. (cf line 525 of the style.css file)
    2. Alternatively you could replace all the button styling with your technique. This will ensure consistency across the site.

    All in I like your addition, but I am going to mark this as Closed (works as designed) and I will leave the styling as intended, feel free to update the patch so that it continues to apply, which will be an easy way to include the override to the default styling using your composer file.

    Thanks again.

  • Pipeline finished with Success
    10 months ago
    Total: 213s
    #109344
Production build 0.71.5 2024