- Issue created by @alok_singh
- Status changed to Needs review
10 months ago 6:54am 23 February 2024 - 🇬🇧United Kingdom the_g_bomb
Thank you for the report and the MR, I will review asap.
- 🇬🇧United Kingdom the_g_bomb
There is already styling for node listings in the CSS, it hasn't been applied to nodes and pages as your MR is attempting, however, in any of the versions, it has been applied to a view row.
If you look at the views listing page, you will see the styling, in the demo site:
https://boldy.d9.garethalexander.co.uk/blogwould prefer to re-use the existing styling rather than add more styling that does something very similar.
I will extend the view listing CSS to the node selectors you added in your MR to apply the same styling to a home page listing for example.
Perhaps you will get to it first, though. Thank you for the MR and the work you have done already on this.
-
the_g_bomb →
committed 758105b9 on 8.x-2.x
Issue #3423368 by alok_singh, the_g_bomb: Need space between two...
-
the_g_bomb →
committed 758105b9 on 8.x-2.x
- 🇬🇧United Kingdom the_g_bomb
I have pushed a fix for the article spacing style issue.
Please test and close if it suffices.Before:
After:
- 🇬🇧United Kingdom the_g_bomb
Fixing missing image from test result in comment 7.
Please close if fixed. I will not be merging an addition of new code when the existing code should be amended.
- Status changed to Fixed
8 months ago 9:24pm 26 April 2024 - 🇬🇧United Kingdom the_g_bomb
Closing. Assumed fixed. 1 month with no response.
Automatically closed - issue fixed for 2 weeks with no activity.