- Issue created by @alok_singh
- Merge request !1boldy-3423362: Menu are broken. Needs to be styled. → (Closed) created by alok_singh
- Status changed to Needs review
10 months ago 6:10am 23 February 2024 - 🇬🇧United Kingdom the_g_bomb
Thank you for the report and the MR, I will review asap.
- 🇬🇧United Kingdom the_g_bomb
There is already styling in the menu CSS, it just doesn't seem to be attached to the menu itself in D8/9/10, but if you look at the menus in the D7 demo site:
https://boldy.d7.garethalexander.co.uk/blogYou can see when you hover over Portfolio, that the CSS is there and works. I think I would prefer to re-use the existing styling rather than add more styling that does something very similar.
I can have look at renaming the existing CSS selectors to work and will try to use your new code as a guide to making it work.
Perhaps you will get to it first, though. I appreciate the work you have done already on this, however.
- Status changed to Needs work
10 months ago 12:49pm 2 March 2024 - 🇬🇧United Kingdom the_g_bomb
Having had the quickest of looks it looked like the JS for Superfish may have changed and so now the JS no longer toggles visibility:hidden to visibility:visible.
Without this toggle the class #mainMenu .block-superfish ul li ul never has its default visibility toggled and stays hidden forever.
- 🇬🇧United Kingdom the_g_bomb
I would be happy to have a non-superfish class selector added to the superfish styling which would remove the need for superfish and have the menu styled nicely without SF.
-
the_g_bomb →
committed b43c1484 on 8.x-2.x
Issue #3423362 by alok_singh, the_g_bomb: Menu are broken. Needs to be...
-
the_g_bomb →
committed b43c1484 on 8.x-2.x
- Status changed to Needs review
10 months ago 5:32pm 2 March 2024 - 🇬🇧United Kingdom the_g_bomb
I have pushed a fix for the Superfish menu and styling.
Please test and close if suffice. - Status changed to Fixed
8 months ago 9:00pm 26 April 2024 - 🇬🇧United Kingdom the_g_bomb
Closing. Assumed fixed. 1 month with no response.
Automatically closed - issue fixed for 2 weeks with no activity.