Replace remaining mentions of REQUEST_TIME in comments

Replaced all but one with the API equiv.

The mention in TimeInterface was removed entirely because the comment is talking about replacing things with the API call.

Whoops, @acbramley isn't a novice, but I think they did the work before @andypost tagged this issue as such. 😅

MR mostly looks great. Agreed with removing the line entirely in TimeInterface. Left a suggestion for a tiny nit in the Kernel test from Update module. . 😂

Title and summary are clear. This is comment-only, so no tests needed. MR pipeline is green (as expected). IMHO, this is RTBC with my suggestion applied, and probably even without it. 😊

Thanks,
-Derek

@dww honestly I don't think this is a Novice issue. As you have seen, it takes knowledge/investigation on what each of those comments are describing. For example, noticing the TimeInterface example could be removed entirely.

Since I've been close to all these issues recently I thought it was easier if I just did it.

Yeah, you're probably right. Let's remove the tag, then. 😅

Thanks for resolving the thread. RTBC. Saving credits.

At some point we should redo the hook_enitty_update()/insert() hook documentation to not have documentation examples that pre-date the existence of field API and do direct database queries. But all the changes look good.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Needs follow-up for

$ git grep ' REQUEST_TIME'
core/lib/Drupal/Component/Datetime/TimeInterface.php:23:   * $request_time = REQUEST_TIME;
core/lib/Drupal/Core/Asset/JsCollectionRenderer.php:79:    // URL changed. Files that should not be cached get REQUEST_TIME as
...
core/lib/Drupal/Core/Entity/entity.api.php:575: *   ->condition('changed', REQUEST_TIME - $age, '<')
core/lib/Drupal/Core/Entity/entity.api.php:1179:      'created' => REQUEST_TIME,
core/lib/Drupal/Core/Entity/entity.api.php:1180:      'updated' => REQUEST_TIME,
core/lib/Drupal/Core/Entity/entity.api.php:1202:      'created' => REQUEST_TIME,
core/lib/Drupal/Core/Entity/entity.api.php:1203:      'updated' => REQUEST_TIME,
core/lib/Drupal/Core/Entity/entity.api.php:1225:      'updated' => REQUEST_TIME,
core/lib/Drupal/Core/Entity/entity.api.php:1249:      'updated' => REQUEST_TIME,
...
core/modules/update/tests/src/Kernel/UpdateDeleteFileIfStaleTest.php:45:    // Set the maximum age to a number smaller than REQUEST_TIME - $filectime.

@andypost you might be missing a git pull? Those are the ones fixed in this issue.

quietone → closed merge request !6732

Sorry, yes, I missed to pull

Automatically closed - issue fixed for 2 weeks with no activity.