- Issue created by @solideogloria
- Status changed to Needs review
9 months ago 11:34am 21 February 2024 - 🇮🇳India sarwan_verma
Hi @solideogloria,
I have fixed this issue " watchdog_exception() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0 " and also attached path,
please review and verify. - Status changed to Needs work
9 months ago 3:22pm 21 February 2024 The patch doesn't inject the logger service or use the correct parameters to
Error::logException
.- Status changed to Needs review
9 months ago 3:24pm 21 February 2024 I created a merge request. It maintains backwards compatibility for the constructor in the same way that Core does, so that it won't break other modules.
For an example in Core, see
MenuRouterRebuildSubscriber
.- Status changed to Postponed: needs info
9 months ago 4:34am 29 February 2024 - 🇺🇸United States nicxvan
This is great work both of you!
Just one question, why did you bump the dependency to 10.1?
Thank you for converting to an MR that is the preferred method of contribution.
Once you answer that question I will circle back and get this in.
- Status changed to Needs review
9 months ago 1:37pm 29 February 2024 - Status changed to Fixed
9 months ago 3:43pm 1 March 2024 @nicxvan I forgot to update composer.json with the updated Drupal version requirement. Can you update that to require Drupal 10.1?
- Status changed to Needs work
9 months ago 3:55pm 1 March 2024 - Merge request !7Resolve #3422714 "Watchdogexception is deprecated" → (Closed) created by solideogloria
- Status changed to Needs review
9 months ago 4:12pm 1 March 2024 I don't know why some commits are duplicated, however I think it should merge fine.
- 🇺🇸United States nicxvan
Good catch, I actually opened another issue here: https://www.drupal.org/project/views_templates/issues/3425014 🐛 Update Composer to match module requirements Active
I'll credit you over there and merge that in momentarily.
- Status changed to Fixed
9 months ago 5:24pm 1 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.