[beta6] Static link to homepage in pattern's twig files (header & footer)

Extra-information : we should use drupal mechanisms path() or ur() instead of hard href so url can be altered by Drupal core, contrib and custom modules.

Hello,

we should use drupal mechanisms path() or ur() instead of hard href so url can be altered by Drupal core, contrib and custom modules.

We shouldn't use those functions (path() & url()) in a component templates. They are stateful and application related because they do DB query to get routing information.

However, I understand you are not comfortable with hardcoding "/" in the template. A better solution would be to add a new URL prop ("settings") in https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/... :

  settings:
    home_url:
      type: url
      label: Homepage URL
      preview: /

Use it in https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/... :

 {% if home_url and (not operator_logo) and (not service_title) %}
  <a href="{{ home_url|default("/") " title="{{ 'Homepage'|t }} - {{ logo_text }}">
{% endif %}
...

And then you can use path() or url() from https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/... :

  {{ pattern('header', {
    'logo_text': page.logo,
    'home_url': path('<front>'),
    'operator_logo': page.header_operator_logo,
    'service_title': site_name,
    'service_tagline': site_slogan,
    'tools_links': page.header_tools_links,
    'tools_search': page.header_tools_search,
    'navbar': page.header_navbar,
  }) }}

hello,
the issue also occurs in the footer pattern

MR !57 ready for review :)

You didn't change page.html.twig?

hello Pierre, you are right, i will push it now.
thank you for checking carefully :)

Automatically closed - issue fixed for 2 weeks with no activity.