Option to enter expiry period in days instead of seconds

Created on 20 February 2024, 10 months ago
Updated 22 February 2024, 10 months ago

Problem/Motivation

For long expiry periods, it can be hard to understand the value in seconds, and could lead to mistakes.

Proposed resolution

Add a configuration boolean field to alter the settings form -

  • disable the expiry_seconds field
  • add an expiry_days field
  • calculate and store expiry_seconds from expiry_days

The behaviour of the module does not change, only the way that expiry_seconds is saved.

✨ Feature request
Status

Closed: won't fix

Version

2.1

Component

User interface

Created by

πŸ‡¬πŸ‡§United Kingdom polynya

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @polynya
  • Pipeline finished with Failed
    10 months ago
    Total: 399s
    #99306
  • Pipeline finished with Failed
    10 months ago
    Total: 296s
    #99327
  • Pipeline finished with Failed
    10 months ago
    Total: 341s
    #99382
  • Issue was unassigned.
  • Status changed to Needs review 10 months ago
  • πŸ‡¬πŸ‡§United Kingdom polynya

    The pipeline is reporting errors in PHPCS and PHPUnit, but they are not related to this change.

  • Status changed to RTBC 10 months ago
  • πŸ‡¬πŸ‡§United Kingdom siliconmeadow

    LGTM

  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    Will wait for the other maintainers to chime in but personally I'm not keen on this.
    If we must do it, would prefer the input to be something like interval field where there's two fields inline one number, and one interval (e.g. days, weeks, seconds, minutes etc)

  • πŸ‡¦πŸ‡ΊAustralia acbramley

    I personally don't agree with this. The checkbox makes the UX confusing (you're checking a checkbox and then entering a number of days into a field that says seconds)

    If this was a form that required interaction more often than once in a blue moon I think it'd make sense to improve the UX but this is just something you could calculate in the background (e.g google "5 days in seconds" and copy the value).

  • πŸ‡¬πŸ‡§United Kingdom siliconmeadow

    I understand the concern. I've had a look though and when installing, by default it's seconds:

    If you choose days, the form changes to:

    and the Expiry seconds becomes readonly.

  • Status changed to Closed: won't fix 10 months ago
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Sorry, I missed the second field. I still don't think this is something we want to or need to support.

Production build 0.71.5 2024