- Issue created by @nterbogt
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:39pm 20 February 2024 - π¦πΊAustralia nterbogt
I think this is ready for a review. At least in terms of the functionality it provides. Happy to discuss specific implementation.
- Status changed to Needs work
about 1 year ago 11:17pm 21 February 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
+1 to the concept
Not sure about the changes to local task deriver though.Left a comment on how to get the list builder without being container aware
- π¦πΊAustralia nterbogt
Updated with new method to get the list builder and tested locally.
The local task deriver changes were because I originally had another change in mind, but rejected it. The change only removes unused variables and uses constructor promotion, bringing it in line with other modernised code in EH 5.x. So decided to include it.
- Status changed to Needs review
about 1 year ago 1:34am 22 February 2024 - Status changed to Needs work
about 1 year ago 1:55am 22 February 2024 - π¦πΊAustralia nterbogt
Tests failed. In theory there was no functional change from previous code. I'll look into it.
- Status changed to Needs review
about 1 year ago 5:21am 23 February 2024 - π¦πΊAustralia nterbogt
Ok, misunderstood the code. Back to passing now. (Note to self) Next time, just run the module in a sandbox with working tests... makes it easier :)
-
larowlan β
committed 5993d799 on 5.x authored by
nterbogt β
Issue #3422592 by nterbogt, larowlan: Expose 'operations' to children...
-
larowlan β
committed 5993d799 on 5.x authored by
nterbogt β
- Status changed to Fixed
about 1 year ago 2:56am 29 February 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Automatically closed - issue fixed for 2 weeks with no activity.