Expose 'operations' to children reorder view

Created on 20 February 2024, 7 months ago
Updated 14 March 2024, 7 months ago

Problem/Motivation

Currently the 'edit' operation is hard coded into the display. It's missing the other operations.

Steps to reproduce

Proposed resolution

Change it to use the operations list from entity list builder so that it's maintained by core and always up to date.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

5.0

Component

Code (module)

Created by

πŸ‡¦πŸ‡ΊAustralia nterbogt

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nterbogt
  • Pipeline finished with Success
    7 months ago
    Total: 286s
    #99289
  • Pipeline finished with Success
    7 months ago
    Total: 378s
    #99299
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia nterbogt

    I think this is ready for a review. At least in terms of the functionality it provides. Happy to discuss specific implementation.

  • Status changed to Needs work 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    +1 to the concept
    Not sure about the changes to local task deriver though.

    Left a comment on how to get the list builder without being container aware

  • πŸ‡¦πŸ‡ΊAustralia nterbogt

    Updated with new method to get the list builder and tested locally.

    The local task deriver changes were because I originally had another change in mind, but rejected it. The change only removes unused variables and uses constructor promotion, bringing it in line with other modernised code in EH 5.x. So decided to include it.

  • Status changed to Needs review 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia nterbogt

    Sorry, forgot status change.

  • Pipeline finished with Failed
    7 months ago
    Total: 284s
    #101081
  • Pipeline finished with Failed
    7 months ago
    Total: 311s
    #101083
  • Status changed to Needs work 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia nterbogt

    Tests failed. In theory there was no functional change from previous code. I'll look into it.

  • Pipeline finished with Canceled
    7 months ago
    Total: 235s
    #101091
  • Pipeline finished with Failed
    7 months ago
    Total: 390s
    #101093
  • Pipeline finished with Failed
    7 months ago
    Total: 398s
    #101109
  • Pipeline finished with Failed
    7 months ago
    Total: 306s
    #101111
  • Pipeline finished with Success
    7 months ago
    Total: 339s
    #102016
  • Status changed to Needs review 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia nterbogt

    Ok, misunderstood the code. Back to passing now. (Note to self) Next time, just run the module in a sandbox with working tests... makes it easier :)

  • Pipeline finished with Success
    7 months ago
    Total: 287s
    #102017
  • Pipeline finished with Skipped
    7 months ago
    #106549
  • Status changed to Fixed 7 months ago
  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    Cheers

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024