- Issue created by @donquixote
- Status changed to Needs review
9 months ago 5:47am 20 February 2024 - 🇮🇳India dineshkumarbollu
Hi @donquixote
The After removing the unused js file behaviour of module working as expected, created patch and test the behaviour in my system,Attaching Screenshot along with patch, Please review.
- Status changed to RTBC
9 months ago 11:25am 20 February 2024 - 🇩🇪Germany donquixote
Looks good to me.
I don't know if there are more niche cases we need to test, but I don't see what would go wrong.Needs maintainer review.
It would be good to know why this code was added in the first place. Probably a leftover. - 🇩🇪Germany donquixote
Note on BC:
Somebody could have custom code that writes to this object.
Such custom code would no longer work.
But I don't think this module has any commitment to support such custom code.