Contrib.social

Fix all suggestions

Open on Drupal.org →
Created on 18 February 2024, 10 months ago
Updated 4 March 2024, 9 months ago

manual review:

project page is too short. What does "Provides private entity fields functionality." mean? What does the module do? What is the use case?

field_extra_form_alter(): You load your config on every single form in Drupal. Instead, it would be better to only load the config after you checked that this is an entity form.

field_extra_schema(): I would not combine key of multiple properties and instead have a column for entity type and field name, to be better query-able in the future.

field_extra_schema(): a primary key is already an index, no need to define it as index again.

field_extra_entity_field_access(): Cache context information is missing. Probably all access results are cachePerUser(), right?

FieldExtraForm::buildForm(): Don't put class names in strings, use PHP ::class syntax

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine AstonVictor

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024