Move batch functionality into check plugin

That was not too bad. I ported the name passwords check. I also added a convenience method to the base class, that means that descendent plugins can implement the doRun() method like they were implementing the old run() method without having to worry about the batch stuff. If this is considered a good way forward, I think we should create follow-up tickets to port the other batches. This change itself is BC-breaking, but it doesn't prevent the old style of batch creation.

I replaced a call to the Drupal global project with "real" dependency injection, but that willl almost certainly cause a conflict with 📌 Reduce number of dependencies in SecurityCheckBase Needs review .

Haven't reviewed yet but merged in the other ticket and that small phpcs.

Would like to see if there's any way to fix the warnings coming from

$instance->extensionPathResolver = $container->get('extension.path.resolver');

Incompatible types

That's weird. Where do you see that? I have the Symfony Support and Drupal Symfony Bridge plugins installed in my PHPStorm to get rid of such errors.

Fixed order of use statements phpcs was complaining about.

Just in my phpstorm, it's not the end of the world. Am trying to review later today though.

If there are other checks to extend to can open up follow ups for them. Hate trying to do all in one as 1 check could hold the rest.

Got around to reviewing and testing that the NamePassword check still runs and catches findings correctly.

I created 📌 Port upload extensions batch to new plugin mechanism Active and 📌 Port views access batch to new plugin mechanism Active for the remaining batches. I don't think those are needed to be done before a stable 3.0.0, since (AFAICT now) they won't need any API changes.

Update attribution

Automatically closed - issue fixed for 2 weeks with no activity.