Add @adriancid as a co-maintainer for Form mode manager

Created on 15 February 2024, about 1 year ago
Updated 7 March 2024, about 1 year ago

@dww - I'm offering to be the new maintainer for this module if you and others are no longer interested. I have several other modules, a theme, years on Drupal, and are able to opt into security.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Miscellaneous

Created by

πŸ‡ΊπŸ‡ΈUnited States mferanda

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mferanda
  • Status changed to Postponed: needs info about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States dww

    Hi @mferanda, thanks for your interest and offer to help!

    However, https://www.drupal.org/project/issues/search/form_mode_manager?project_i... β†’ shows only this issue here as one that you're even following in this module's issue queue. You've never participated in any other issues, never submitted a patch, never reviewed another person's patch, etc. I can't make you a co-maintainer if I have no idea how careful you are as a coder, what your approach is, or what it's like working together. πŸ˜…

    If you want to be a co-maintainer, please start meaningfully contributing to this project. Once you do, I'll get to know your abilities, style, and your ideas for the direction of the module. You can triage the queue looking for duplicates. You can review + test patches that are "RTBC" or "Needs review". You can work on things that "Need work", etc. Anything you can do to move issues forward will help me get a sense of your capabilities.

    Thanks again!
    -Derek

    p.s. When you sent the message to me about your interest in this module via my contact tab, it would have been great had you included a link to this issue. I had to search for it to reply. ;)

  • πŸ‡ΊπŸ‡ΈUnited States mferanda

    Not sure what you mean on the p.s.. I sent a link to this issue in my message to you, mainly because you said similar to someone else. Looked like it was in the copy sent to me.

    I’ll start digging through the code further when I have a moment. Might be easier if I just create something new on drupal.org

  • πŸ‡ΊπŸ‡ΈUnited States dww

    Whoops, sorry about the p.s. That was copy/paste from the reply to the other request. You did include the link in your message, thanks!

    I'm not encouraging you to fork this module or otherwise add Yet-Another-Module on d.o. If you want to contribute, please do! I just don't give out push access to modules I (co)maintain without any info about the developer I'd be allowing commits from. Hope you understand and don't take it personally.

    Thanks,
    -Derek

  • πŸ‡ΊπŸ‡ΈUnited States dww

    p.p.s. I'm no longer working for the client that needed this module. I don't use it on any sites. I basically don't care about this at all. πŸ˜… So perhaps anyone, regardless of their abilities / intentions, would be a better maintainer than myself. πŸ˜‚ It's funny how a sense of "responsibility" can be so selective.

  • Status changed to Needs review about 1 year ago
  • πŸ‡¨πŸ‡¦Canada adriancid Montreal, Canada

    Hi @dww, I'm using this module in a project, and we will love to have the D10 version ready, if you want to know a little about my intentions maintaining modules you can check profile (I don't think I contributed here before but I contribute in a lot of other projects), you will see there I'm one of the main maintainers of Admin Toolbar.

  • Status changed to Fixed about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States dww

    Thanks for the offer, @adriancid! Absolutely no offense to anyone else, but when I saw the comment, I said to myself: "Finally, a name I recognize volunteering for the task." 😊 Given your history and experience (including issues we've collaborated on before), I trust you to be a very responsible maintainer. Welcome aboard! πŸŽ‰

    Because it's the only way to give you proper access to configuring GitLab for this project, I made you a "full maintainer", including the ability to change the maintainers. But please do not add additional co-maintainers without a +1 from me in an issue about it.

    It'd be fabulous to resolve πŸ“Œ Setup GitLab CI for form_mode_manager Active soon, and fix any phpcs, phpstan, etc that turns up so we have clean, green GitLab CI pipelines here.

    I'm trying to only commit things (both here and other projects) that have automated tests.

    I personally hate the default git commit messages provided by the d.o issue UI and the conventions used for years. I've been on a campaign to try to change them. I've started experimenting with alternatives as you'll see in the git history here (and at address, pathologic, etc). Feel free to do the same, but if you default to the easy thing provided by the issue UI, I won't blame you. πŸ˜‚

    Feel free to ping me anytime in Slack. I don't have email notifications enabled for this project. πŸ˜… Maybe I should. πŸ˜†

    Thanks again!
    -Derek

  • πŸ‡¨πŸ‡¦Canada adriancid Montreal, Canada

    Thanks Derek,

    The first task I will be doing is creating the D10 release, and for sure I will try to follow your instructions, if I have some questions I will write you in Slack.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024