- Issue created by @joseph.olstad
- Merge request !22Issue #3421466: Splits: Ensure config_ignore works for everyone - set default to functional value β (Open) created by joseph.olstad
- πΈπͺSweden mohammed motar
We are using config_split 2.0.0 and config_ignore 3.2.
We have tried the patch and it does not work, the ignored configuration still exports. - π¨π¦Canada joseph.olstad
@Mohammed Motar
this patch is to ensure that ignored configuration still IMPORTS
it's up to you to ignore your exports, this issue is for IMPORTS - π¨π¦Canada joseph.olstad
From the issue summary above:
Set the default import priority to -1.
- π¨πSwitzerland bircher π¨πΏ
There is an argument which can be made to set it to -100 for example.
But I am also interested in what people who use these two modules in combination expect to happen on export.
- π¨π¦Canada joseph.olstad
@bircher,
this issue is for the import operation and the patch only deals with the import priority default. The ignore on import is the most important functionality of the config_ignore module.I propose separating export questions into a new issue.
- Status changed to Postponed: needs info
10 months ago 9:46am 11 March 2024 - π¨πSwitzerland bircher π¨πΏ
This is not the only issue where people report problems with the interaction of config split and config ignore. But this issue seems to have the most practical solution.
So I am curious what the expectations are for exporting the configuration. I have some ideas of what could be done but that would add another wrinkle and wouldn't be trivial and one could configure it to work that way already so I don't know if it is worth it without having some feedback from people using the two modules in conjunction. - π¨π¦Canada joseph.olstad
Ok, personally I think the most critical fix that is needed is to fix the ignoring with splits. This is what the merge request does accomplish.
I believe exporting could be fixed quite easily with the same approach. With that said, on some projects I'd like split exports to be ignored also, on others maybe not. I consider this a seperate issue so to keep things simple I'd like to focus entirely on the import ignore for this issue.
For the export ignore I think the solution should be configurable so that we can turn it on or off.
We could do a configurable on/off split ignore thing for import ignore however I do not recall one single use case that I have hit other than wanting to have a comprehensive ignore when ignore is turned on I want it to always ignore imports. Some people may disagree.
So this fixes:
- ignore imports that are split
I say push through the merge request and as a followup someone could work on three new issues
- ignore exports that are split
- optional ignore exports that are split
- optional ignore imports that are split
These last three being new issues seperate issues.
- Status changed to Needs review
10 months ago 2:06am 13 March 2024 - Issue was unassigned.
- π¨π¦Canada joseph.olstad
patch is working as expected in multiple environments.
With this change, our ignore definitions apply to splits as expected.
-
bircher β
committed 43b2f7c8 on 8.x-3.x
Issue #3421466 by joseph.olstad, bircher: set default event subscriber...
-
bircher β
committed 43b2f7c8 on 8.x-3.x
- Status changed to Fixed
9 months ago 10:26am 14 April 2024 - π¨πSwitzerland bircher π¨πΏ
I set the default priority to -100 because that is a big round number which allows for plenty of numbers between.
I also set the same to the export and that will make it work for splits that use the collection storage. Splits not using the collection storage will have to manually be set to come after -100 and set to stackable. I don't think there is another way to solve this in a generic way. If this is something that someone feels strongly about I would suggest fixing that in a contrib module.
- π¨π¦Canada joseph.olstad
Hi @bircher, sounds good, with that said, I haven't tested -100 yet, I only tested 0
Automatically closed - issue fixed for 2 weeks with no activity.