- Issue created by @gogowitsch
- Status changed to Needs work
9 months ago 6:58pm 14 February 2024 - ๐บ๐ธUnited States danflanagan8 St. Louis, US
Whoa! How did this happen?!?
I checked the git history on Drupal\migrate\Plugin\migrate\destination\Entity.php and found this issue: ๐ Fix migrate destination entity PHPStan L0 issues Fixed
Looks like that was committed to 11.x. I think the module should still work with D10.x. Otherwise I would reclassify this as critical.
Thatnks for the patch, @Gogowitsch. It looks like the right fix. We need to add that good old inherit to the docblock of the new method. Back to NW for that.
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 6:55am 15 February 2024 - Status changed to Needs work
9 months ago 1:43pm 15 February 2024 - Status changed to Needs review
9 months ago 3:24pm 16 February 2024 - ๐ฉ๐ชGermany gogowitsch
New patch ahead! I could not push to the fork in the MR, with Git telling me โYou are not allowed to push code to this project.โ
I have moved the empty function to the base class
MigrateSandboxEntity
and fixed the phpcs errors. - Status changed to RTBC
9 months ago 9:30pm 29 February 2024 - ๐บ๐ธUnited States danflanagan8 St. Louis, US
Patch looks great. Thank you, @Gogowitsch!
-
danflanagan8 โ
committed 106b6472 on 1.1.x authored by
Gogowitsch โ
Issue #3421443 by Gogowitsch, danflanagan8: Fatal error: Class...
-
danflanagan8 โ
committed 106b6472 on 1.1.x authored by
Gogowitsch โ
- Status changed to Fixed
9 months ago 9:53pm 29 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.