With 📌 Integration with Gitlab CI Fixed in place, we can start checking for PHPStan. There is a report now for the issues we can fix.
------ -----------------------------------------------------------------------------------
Line src/AdminToolbarContentPluginBase.php
------ -----------------------------------------------------------------------------------
156 Unsafe usage of new static().
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
691 \Drupal calls should be avoided in classes, use dependency injection instead
------ -----------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line src/Form/AdminToolbarContentSettingsForm.php
------ -----------------------------------------------------------------------------------
45 Unsafe usage of new static().
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
144 \Drupal calls should be avoided in classes, use dependency injection instead
------ -----------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line src/Plugin/Derivative/AdminToolbarContentMenuLinks.php
------ -----------------------------------------------------------------------------------
37 Unsafe usage of new static().
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ -----------------------------------------------------------------------------------
Run phpstan analyse
Fixed
2.0
Code
Issue #3421310 by tim-diels: Fix issues reported by PHPStan