- Issue created by @pbosmans
- Status changed to Needs review
12 months ago 1:45pm 15 February 2024 - ππΊHungary boobaa
Attached is a patch that solves the problem of importing images into the private FS; pretty much the same approach, but also contains tests.
- ππΊHungary boobaa
The MR is the same as the patch in #3, and works well with 1.4.6.
- ππΊHungary mxr576 Hungary
MR failed on automated qa, back to needs work.
+1 I am looking for this feature also! Is anything more needed before it can be merged?
I pulled it from git to try and found that it breaks on imports of previously-exported content.
The error occurs because the importAssets function only handles the new path options of 'assets/public' and 'assets/private' but not the old one of simply 'assets'.
I think this needs to be at least documented and probably the old behavior should be replicated for import of old exports. I am fixing it that way in my dev copy and would be happy to update the issue branch if that is agreeable and someone can guide me on the appropriate way to do it.
I just tested it and it works fine. Just a one-line code fix to line 435's search and replace values.
- πΊπ¦Ukraine nginex
Thanks for the patch!
I extended the logic a bit to work with any file schema not only private and public.