There are two methods that do almost the same thing.
- moveMenuItem() moves an item to a new sibling, but also has some extra speed related handling when calling it repeatedly as is done by matchPattern()
- changeMenuItemSibling() is more clearly named but lacks the internal handling.
It would be nice to have changeMenuItem() keep the internal handling but for the actual work of changing the sibling, have it call changeMenuItemSibling(). This would reduce the amount of repeated code and possible points of failure / tech debt.
Steps to reproduce
User interface changes
Data model changes