Resolve method moveMenuItem is near duplicate of changeMenuItemSibling

Created on 12 February 2024, 12 days ago

Problem/Motivation

There are two methods that do almost the same thing.

  • moveMenuItem() moves an item to a new sibling, but also has some extra speed related handling when calling it repeatedly as is done by matchPattern()
  • changeMenuItemSibling() is more clearly named but lacks the internal handling.

It would be nice to have changeMenuItem() keep the internal handling but for the actual work of changing the sibling, have it call changeMenuItemSibling(). This would reduce the amount of repeated code and possible points of failure / tech debt.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States swirt Florida

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build https://api.contrib.social 0.61.6-2-g546bc20