Contrib.social

Remove PhpUnitTestRunner process execution timeout

Open on Drupal.org →
Created on 12 February 2024, 12 months ago
Updated 26 February 2024, 11 months ago

Problem/Motivation

In 📌 Use Symfony Process to spawn subprocesses in PhpUnitTestRunner Needs review we added a new timeout for tests. I think this was incorrect for the following reasons:

  • We have no idea how long contrib and custom tests take (on whichever CI run on or a local machine).
  • Long debug sessions now are impossible
  • The process time last for the whole test - if a test class contains lots of tests this will not allow you to run the whole test locally.

Steps to reproduce

Proposed resolution

  • If we really want to enforce some timeout on tests then it should apply on the test level method.
  • It should be introduced first as a notice so people can adjust things.
  • It should be configurable.

But personally I think we should not do this. CI have timeouts and locally you can kill the test. This is not an improvement.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Fixed

Version

11.0 🔥

Component
PHPUnit  →

Last updated about 21 hours ago

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024