- Issue created by @nkind
- 🇨🇦Canada nkind
Was able to make this issue and change thanks to my employer zu
- Status changed to Needs review
10 months ago 3:13pm 8 February 2024 - Issue was unassigned.
- 🇫🇷France flocondetoile Lyon
Why have you added the file_url_generator service as argurment for the entity_export_csv.manager service ? It's not needed (and not used in the manager).
I wonder if the file_url_generator should be injected into the FileExport Class instead of the FieldTypeExportBase Class. Does the file_url_generator could be used by other field type plugin than the FileExport plugin ? Let's it as actually for now.
And as we change the constructor of the FieldTypeExportBase class, shouldn't we trigger a cache rebuild by implementing an empty hook_update_N() ?
- Status changed to Needs work
7 months ago 9:40am 30 April 2024 - 🇨🇦Canada nkind
Instead of an `empty hook_update_N()` I saw that we should use `hook_post_update_NAME` for this functionality based on this https://www.drupal.org/node/2960601 →
I updated the MR accordingly with a `entity_export_csv.post_update.php` file.
- Status changed to Needs review
7 months ago 4:07pm 30 April 2024 - b2c39459 committed on 2.x
Issue #3420140 by nkind, flocondetoile: Add file URL as a format option
- b2c39459 committed on 2.x
- Status changed to Fixed
2 months ago 2:18pm 12 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.