- Issue created by @longwave
- Status changed to Needs review
12 months ago 11:24am 8 February 2024 - 🇬🇧United Kingdom longwave UK
MR!6504 pipeline should show the CSS and JS lint jobs being skipped. The other two MRs should run one of the jobs as required.
- 🇬🇧United Kingdom longwave UK
@catch suggested skipping some of the PHP jobs in a similar way, but I think we have to be more careful; for example tests can rely on pretty much any file in the repo as a fixture, and we would want to rerun the tests if these are changed. I think we can probably skip PHPStan based on file extension, but let's explore that in a followup.
- 🇬🇧United Kingdom catch
+1 to merging the compilation check, it won't add any real time to pipelines but it'll save a minute or so of runner time every job.
It is slightly disconcerting seeing less jobs, even though I was explicitly reviewing this MR I was thinking "where've they gone!". I'm not sure if we want to leave something in their place when they're skipped (like the 'manual' button) just for consistency?
- Status changed to Needs work
12 months ago 1:59pm 8 February 2024 - 🇬🇧United Kingdom longwave UK
Yeah, let's add a manual button, then we can run then in special extra cases too if we need to.
- Status changed to Needs review
12 months ago 2:26pm 8 February 2024 - 🇬🇧United Kingdom catch
I see a skipped CSS run on https://git.drupalcode.org/project/drupal/-/pipelines/90615 but not eslint, however is that because eslint is linting the YAML that we're changing in the MR? If so, RTBC for me.
- 🇬🇧United Kingdom longwave UK
Yes, I realised that ESLint also covers YAML, and added it to the set of changed file patterns, so it runs on this MR now.
(PHPCS also lints YAML, but we should probably stop doing that now ESLint does a better job)
- Status changed to RTBC
12 months ago 11:17pm 8 February 2024 - 🇬🇧United Kingdom catch
OK this is great then, we might find other things later, but can sort that out later.
Skipping YAML in the phpcs job seems like a good idea but can be its own issue.
- Status changed to Fixed
12 months ago 12:30pm 12 February 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.