Do not run pipelines on tags for Drupal core

Note that core makes reference to the workflows file here: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

So the options are to fix it here or to remove the reference from core to the file and bring the rules to the core ".gitlab-ci.yml". In this last case, the issue could be moved to the core queue.

MR ready: https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/123

Will try to test it here 📌 [Test] Do not run GitLab CI on tags Closed: works as designed and report back.

What does core's GitLab CI actually use from the templates? Because the way core does things is quite different to contrib anyway, I wonder if we should just diverge entirely and stop using the includes.

Testing from 📌 [Test] Do not run GitLab CI on tags Closed: works as designed

- MR for core pointing to this branch of the templates: https://git.drupalcode.org/project/drupal/-/merge_requests/6500/diffs
- First pipeline (normal MR commit): https://git.drupalcode.org/issue/drupal-3419995/-/pipelines/90316 (runs as expected)
- Created some tags in the fork (https://git.drupalcode.org/issue/drupal-3419995/-/tags):
-- First runs fail as reported because the fork has a different name: https://git.drupalcode.org/issue/drupal-3419995/-/jobs/771798
-- Then I added the rule for this fork too here: No new pipelines were created for tags, which is expected. See "test-tag10" in https://git.drupalcode.org/issue/drupal-3419995/-/tags

Commits where we can see that "test-tag10" did not have a piipeline.
https://git.drupalcode.org/issue/drupal-3419995/-/commits/3419995-test-d...

@longwave

What does core's GitLab CI actually use from the templates? Is it just the default rules and perhaps some variables?

Yes, it uses the full variables file and the workflow file. See here: https://git.drupalcode.org/project/drupal/-/blob/11.x/.gitlab-ci.yml?ref...

I suggested that as an option in the slack thread. This seemed like the easiest place to do the change but I agree that we could just include the code in core and then have them evolve different ways.

I'm happy to not change anything here in the templates and to move things to core as needed if that's the agreement.

We will NOT fix this in favor of 📌 Bring external template files into core RTBC

fjgarlin → closed merge request !123