- Issue created by @fjgarlin
- Status changed to Needs review
over 1 year ago 11:48am 8 February 2024 - 🇪🇸Spain fjgarlin
Pending pipelines coming green (https://git.drupalcode.org/issue/drupal-3420042/-/pipelines/90419), this is ready to review.
- 🇬🇧United Kingdom catch
This is a lot less than I would have expected to need to bring in, so makes sense to consolidate.
- Status changed to Needs work
over 1 year ago 12:02pm 8 February 2024 - Status changed to Needs review
over 1 year ago 12:25pm 8 February 2024 - 🇪🇸Spain fjgarlin
All questions/feedback were addressed.
Only one of them wasn't done, and I gave my reasons why I think it's ok to leave it as it is.
- Status changed to RTBC
over 1 year ago 1:22pm 8 February 2024 - 🇬🇧United Kingdom longwave UK
OK, let's leave the variable as-is for now, it can't hurt. The other changes look good and simplify things a bit further, I think this is ready to try for real!
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 1366a3ae13 to 11.x and 129230f1c3 to 10.3.x and da6376b9b9 to 10.2.x. Thanks!
Backported to 10.2.x as this is not runtime code.
-
alexpott →
committed da6376b9 on 10.2.x
Issue #3420042 by fjgarlin, longwave, catch: Bring external template...
-
alexpott →
committed da6376b9 on 10.2.x
-
alexpott →
committed 129230f1 on 10.3.x
Issue #3420042 by fjgarlin, longwave, catch: Bring external template...
-
alexpott →
committed 129230f1 on 10.3.x
- Status changed to Fixed
about 1 year ago 11:07pm 28 February 2024 -
alexpott →
committed 1366a3ae on 11.x
Issue #3420042 by fjgarlin, longwave, catch: Bring external template...
-
alexpott →
committed 1366a3ae on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.