Contrib.social

Add description on values provided in area

Open on Drupal.org →
Created on 7 February 2024, 9 months ago
Updated 2 August 2024, 4 months ago

Problem/Motivation

In the Drupal 10.1.x postExecute method was introduced 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Fixed for the Some pager.
Developers/users should be informed that the value set in this pager affects on total_items count.

Steps to reproduce

- place Extra Result summary area with all the provided tokens in the view;
- set Pager "Display a specified number of items" and the number of values to 10.

Full pager.

Display a specified number of items - 10.

@total, @page_count, @more token values were affected.

Proposed resolution

Place a description on an area form that makes clear the effect of the Some pager usage on those token values.

Remaining tasks

-

User interface changes

New description will be added on the form.

API changes

-

Data model changes

-

📌 Task
Status

Needs work

Version

3.0

Component

User interface

Created by

🇺🇦Ukraine paulrad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @paulrad
  • Merge request !5#3419820 - added notice about the Some pager effect on tokens in the description → (Open) created by paulrad
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇺🇦Ukraine paulrad
  • Pipeline finished with Success
    9 months ago
    Total: 230s
    #89834
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

    _paulrad,

    Please, fix the coding standards that we get after pipelines.

    phpcs:

    FILE: ...ustom/views_extras-3419820/src/Plugin/views/argument_default/TempStore.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Core\TempStore\PrivateTempStoreFactory.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 200ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...ras-3419820/src/Plugin/views/argument_default/TempStore.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 1 ERROR AND 0 WARNINGS WERE FOUND IN 5 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl  1
--------------------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------

    phpstan:

     ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/views/area/ExtraResult.php                                 
 ------ ---------------------------------------------------------------------- 
  52     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/Cookie.php                                  
 ------ ------------------------------------------------------------------------------ 
  75     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/Session.php                                 
 ------ ------------------------------------------------------------------------------ 
  74     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/TempStore.php                               
 ------ ------------------------------------------------------------------------------ 
  84     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 [ERROR] Found 4 errors
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024