- Issue created by @freelock
- Status changed to Needs review
10 months ago 11:41pm 6 February 2024 - πΊπΈUnited States freelock Seattle
Fix pushed.
The original code was checking for an empty value, and replacing with the token name if it is empty. There are clearly values that evaluate to empty that should be posted.
After that, it assumes the value can be evaluated as a string. I'm not sure what other types are being checked here -- if it wasn't a string, then this code wouldn't function at all, unless the substituted value was null, an empty array, or an object that somehow evaluates to empty.
I changed this check to simply check for null. Is there another scenario that needs to be tested here?
- Status changed to Fixed
6 months ago 2:16pm 17 May 2024 - π΅πΉPortugal joaomarques736
Hello freelock, thanks for your contribution. It is already merged in the branch 3.x, thanks!
- Status changed to Fixed
6 months ago 2:57pm 17 May 2024