- Issue created by @rupertj
- Status changed to Needs review
11 months ago 3:20pm 6 February 2024 - 🇬🇧United Kingdom rupertj Bristol, UK
Uploading a patch that implements a setting to keep existing IDs when filtering.
- 🇬🇧United Kingdom rupertj Bristol, UK
Good call. Here's a updated patch with a unit test for the new option.
- Status changed to RTBC
8 months ago 11:43am 30 April 2024 - 🇧🇪Belgium dieterholvoet Brussels
I was looking for the same thing in order to make this module work with the CKEditor ID Attributes module → . The latest patch does the job, after enabling the new option in the text format.
- 🇦🇺Australia pingers
Thanks! I'd like to verify in our build, then I'll happily merge.
- 🇨🇦Canada ryanrobinson_wlu
This works for me. I've just started testing the module with this patch, and everything is good so far.
- 🇨🇦Canada ryanrobinson_wlu
After updating to Drupal 10.3, with this patch installed and its functionality in use on two existing text formats, I'm getting this error when I try to save a new text format:
'keep_existing_ids' is not a supported key.
It does not matter if the new format has the "Automatically apply identifiers (anchors) to headings in content" filter is enabled or not. The error occurs either way.
Removing the patch does fix it, which makes sense since that key identified is pretty clearly tied to this patch.
I'm not sure what the fix is - is there something else that needs to be done to declare that key as supported?
- Status changed to Needs review
6 months ago 2:09pm 26 June 2024 - 🇧🇪Belgium dieterholvoet Brussels
I added the necessary config schema. Should be fixed in the MR.
- 🇨🇦Canada ryanrobinson_wlu
Thank you. I think that's good again. I tested with the patch option (not overriding existing) still on, removing the patch option, and removing having the filter entirely. No errors from any of them.
- Status changed to RTBC
6 months ago 2:27pm 26 June 2024