Had to disable module because it now relies on node access

Created on 6 February 2024, 11 months ago
Updated 7 February 2024, 11 months ago

Hello,
I just wanted to share with you the fact that I decided to disable this module because it now relies on node_access table. Node access was not enabled so far on our website. We have 68k nodes and I noticed it took 20 minutes to rebuild node access and that pages would not be accessible until their permission is created. I did not want our website pages to be inaccessible for that long and I could not even rely on node_access_rebuild_progressive since the table is currently empty. Hopefully I was not relying on this module for much so a simple custom code in hook_node_access did the trick.

I was curious to hear why you suddenly decided to rely on node access?
Does it have better performance once the permissions are created?
Do you think I am making a mistake by not using your module anymore just because it uses node_access?

Thank you

Nicolas

πŸ’¬ Support request
Status

Closed: works as designed

Version

1.5

Component

Miscellaneous

Created by

πŸ‡«πŸ‡·France nicolas bouteille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nicolas bouteille
  • Status changed to Closed: works as designed 11 months ago
  • πŸ‡ΊπŸ‡¦Ukraine AstonVictor

    Hi Nicolas,

    we used hook_entity_access() before but it doesn't cover all cases. e.g. it doesn't work with queries.

    Creating node grants should not take a lot of time because the code executes for a single node when the node creates/updates.
    After changing permissions, there is no reason to rebuild node grants because we check permissions in hook_node_grants() hook.

    thanks

  • πŸ‡«πŸ‡·France nicolas bouteille

    Thank you for your feedback.
    Indeed, the only moment it would have taken 20 minutes would have been when updating your module. Because at that moment the node_access table is empty and 68k node permission need to be created. But I did not want to have our website down for that long so I uninstalled.

Production build 0.71.5 2024