Node type third_party_settings config schema is missing

Created on 2 February 2024, 5 months ago
Updated 19 February 2024, 4 months ago

Problem/Motivation

Config schema is missing for the node type third_party_settings config. is_single is a boolean, but without config schema it's sometimes saved as integer, sometimes as boolean.

Steps to reproduce

Change the node type settings. The is_single config value is saved as integer.

Proposed resolution

Add config schema.

πŸ› Bug report
Status

Fixed

Version

3.3

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium DieterHolvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @DieterHolvoet
  • πŸ‡§πŸ‡ͺBelgium DieterHolvoet Brussels
  • Status changed to Needs review 5 months ago
  • Status changed to RTBC 5 months ago
  • πŸ‡§πŸ‡ͺBelgium Robin.Houtevelts

    Seems to work! Thanks!
    Not sure this is worthy of a changelog entry, so LGTM πŸŽ‰

    diff --git a/config/sync/node.type.article.yml b/config/sync/node.type.article.yml
    index 0a94094b7..d259d783e 100644
    --- a/config/sync/node.type.article.yml
    +++ b/config/sync/node.type.article.yml
    @@ -7,7 +7,7 @@ dependencies:
         - node_singles
     third_party_settings:
       node_singles:
    -    is_single: 0
    +    is_single: false
       menu_ui:
         available_menus: {  }
         parent: ''
    diff --git a/config/sync/node.type.homepage.yml b/config/sync/node.type.homepage.yml
    index dcf01fd47..6aae14164 100644
    --- a/config/sync/node.type.homepage.yml
    +++ b/config/sync/node.type.homepage.yml
    @@ -10,7 +10,7 @@ third_party_settings:
         available_menus: {  }
         parent: ''
       node_singles:
    -    is_single: 1
    +    is_single: true
     name: Homepage
     type: homepage
     description: 'Homepage (homepage)'
    --- a/config/sync/node.type.news_overview.yml
    +++ b/config/sync/node.type.news_overview.yml
    @@ -10,7 +10,7 @@ third_party_settings:
         available_menus: {  }
         parent: ''
       node_singles:
    -    is_single: 1
    +    is_single: true
     name: 'News overview'
     type: news_overview
     description: 'News overview (news_overview)'
    
    ...
    
  • Pipeline finished with Skipped
    5 months ago
    #87751
  • Status changed to Fixed 5 months ago
  • πŸ‡§πŸ‡ͺBelgium DieterHolvoet Brussels
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024