- Issue created by @firewaller
- Status changed to Needs review
about 1 year ago 1:15am 2 February 2024 - Status changed to Needs work
about 1 year ago 3:17pm 2 February 2024 - 🇺🇸United States smustgrave
Can we get a test case to show how this is an issue/
JS skips optimization here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
But CSS does not: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
When a JS library is `minified: true` it will skip optimization. When a CSS library is `minified: true` it will not skip optimization.
Add the same logic from `\Drupal\Core\Asset\JsCollectionOptimizerLazy::optimizeGroup` to `\Drupal\Core\Asset\CssCollectionOptimizerLazy::optimizeGroup`:
// Optimize this CSS file, but only if it's not yet minified.
if (isset($css_asset['minified']) && $css_asset['minified']) {
$data .= file_get_contents($css_asset['data']);
}
else {
$data .= $this->optimizer->optimize($css_asset);
}
Needs work
11.0 🔥
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Can we get a test case to show how this is an issue/