Contrib.social

Generating QR Code without logo creates error

Open on Drupal.org →
Created on 31 January 2024, 11 months ago

Problem/Motivation

$logo is not initialized in Drupal\endroid_qr_code\Response\QRImageResponse so if $this->file is not set, this error is generated in the log:

Warning: Undefined variable $logo in Drupal\endroid_qr_code\Response\QRImageResponse->generateQrCode() (line 143)

Line 143:
$result = $this->writer->write($qrCode, $logo, $label);

The PNGWriter will accept a null $logo.

Proposed resolution

Set $logo = null; before the $this->file check on line 131.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇺🇸United States derekw

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @derekw
  • Merge request !104.0.x → (Open) created by derekw
  • Comment 8 months ago →
    divanova

    Hello, I'm uploading a patch for this issue for version "drupal/endroid_qr_code": "4.0.x-dev@dev", where the problem is still there.

    I'm using the DEV version, because the latest 4.0 version is throwing the following error: ValueError: Path cannot be empty in file_get_contents() (Line 24 in /var/www/html/project/vendor/endroid/qr-code/src/ImageData/LogoImageData.php).

  • Status changed to RTBC 12 days ago
  • Comment 12 days ago →
    🇧🇪Belgium dieterholvoet Brussels

    The changes in the MR fix the issue for me.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024