Media and Blocks Admin routes show local tasks as a dropdown top bar instead of tabs

Created on 31 January 2024, 10 months ago
Updated 26 March 2024, 8 months ago

Problem/Motivation

There is some inconsistency from a user pespective of when the local tasks move from being tabs, to being in a dropdown on the Top bar. Specifically this has been noted on the Content (/admin/content) and Files (/admin/content/files) routes. This leads to an awkward user experience as you click through the links in the Content menu where local tasks as presented as a mix of tabs and dropdown.

Steps to reproduce

  1. Enable the navigation module
  2. Navigate to Content (/admin/content) or Files (/admin/content/files) from the Admin toolbar

Expected result

Local tasks are presented as a dropdown in the Top bar.

Actual result

Local tasks are presented as tabs.

Proposed resolution

Include entity collection routes in the logic that moves local tasks. Both Content and Files are provided by views in core.

Remaining tasks

Fix it.

User interface changes

One Content and Files routes, local tasks will be correctly presented as tabs.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇦Canada m4olivei Grimsby, ON

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @m4olivei
  • First commit to issue fork.
  • Pipeline finished with Success
    8 months ago
    Total: 152s
    #117375
  • Status changed to Needs review 8 months ago
  • 🇪🇸Spain plopesc Valladolid

    Created MR for this.

    Once working on it, I realized that behavior for these pages should be tabs instead of top bar options I think.

    Original idea was to have only entity operations in the top bar. Tabs in these pages are not operations like when you are visiting a node, but actual links to different entity listing page.

    Also, the "More actions" label does not make sense to me in this scenario.

    Created a MR to exclude entity collection routes from the NavigationRenderer logic.

    Please test it and we can discuss about the best approach for this issue and rephrase it if you consider it appropriate.

  • 🇨🇦Canada m4olivei Grimsby, ON

    Original idea was to have only entity operations in the top bar. Tabs in these pages are not operations like when you are visiting a node, but actual links to different entity listing page.

    That makes sense! I think we were so focused on the inconsistency, that we didn't consider that it doesn't make sense for collections pages. I'm OK with the change. Here, lets double check with @ckrina, if only to all be on the same page here.

  • 🇪🇸Spain plopesc Valladolid
  • Status changed to Fixed 8 months ago
  • 🇪🇸Spain ckrina Barcelona

    We just discussed this with @plopesc and @m4olivei in slack: only entities should get the dropdown. So merging the work. Thanks!

  • Pipeline finished with Success
    8 months ago
    Total: 149s
    #117445
  • 🇪🇸Spain ckrina Barcelona
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    7 months ago
    Total: 51s
    #153173
  • Pipeline finished with Failed
    7 months ago
    Total: 52s
    #153174
  • Pipeline finished with Success
    7 months ago
    Total: 52s
    #153175
  • Pipeline finished with Success
    7 months ago
    Total: 313s
    #153180
  • Pipeline finished with Success
    7 months ago
    Total: 51s
    #153193
  • Pipeline finished with Success
    7 months ago
    Total: 800s
    #153197
  • Pipeline finished with Success
    7 months ago
    #153358
  • Pipeline finished with Success
    7 months ago
    Total: 54s
    #153362
  • Pipeline finished with Success
    6 months ago
    Total: 270s
    #194763
  • Pipeline finished with Success
    6 months ago
    Total: 180s
    #194773
  • Pipeline finished with Skipped
    4 months ago
    #233988
  • Pipeline finished with Failed
    3 months ago
    Total: 2519s
    #265092
  • Pipeline finished with Canceled
    3 months ago
    Total: 3273s
    #265211
  • Pipeline finished with Failed
    3 months ago
    Total: 1387s
    #265238
  • Pipeline finished with Failed
    3 months ago
    #265303
  • Pipeline finished with Canceled
    3 months ago
    #265331
  • Pipeline finished with Failed
    3 months ago
    Total: 1186s
    #265332
  • Pipeline finished with Success
    3 months ago
    Total: 1323s
    #265357
Production build 0.71.5 2024