- Issue created by @m4olivei
- First commit to issue fork.
- Merge request !170Resolve #3418416 "Cacheing issue with local tasks when 'Hide Top Bar' set and then unset" → (Closed) created by plopesc
- Status changed to Needs review
5 months ago 11:24am 1 February 2024 - 🇪🇸Spain plopesc Valladolid
Add logic to take into account hide_top_bar property and ensure that local tasks are rebuilt when navigation settings form is submitted.
- Merge request !171Issue #3418416: Declare navigation.settings as cacheable dependency → (Merged) created by m4olivei
- 🇨🇦Canada m4olivei Grimsby, ON
@plopsec I took a different approach by instead of invalidating another modules cache tag, properly declaring our cacheability metadata, which I think is the better way to solve this. Let me know what you think. Open to being told I'm wrong 🙂.
https://git.drupalcode.org/project/navigation/-/merge_requests/171
- Status changed to RTBC
5 months ago 7:06am 2 February 2024 - 🇪🇸Spain plopesc Valladolid
@m4olivei Checked your code and it looks cleaner and better for the long run than my original approach.
Closed my MR and marking this issue as RTBC.
Thank you for bringing a second point of view to the issue!
- 🇨🇦Canada m4olivei Grimsby, ON
Thank you for bringing a second point of view to the issue!
My pleasure! Always count on cacheability in Drupal to bring out complications and multiple approaches 😀. Thanks for the review.
-
m4olivei →
committed c0a84ad9 on 1.x
Issue #3418416: Declare navigation.settings as cacheable dependency
-
m4olivei →
committed c0a84ad9 on 1.x
- Status changed to Fixed
5 months ago 1:36pm 6 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.