- Issue created by @roderik
- Status changed to Needs review
10 months ago 4:47pm 31 January 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
The patch is just for our build system.
Given the second tagged-on functionality, maybe you want to change the commit message completely -- but that's up to you.
- 🇧🇪Belgium dieterholvoet Brussels
Just out of curiosity: why do you want to override the config this way? You know you can override config in settings.php, right?
-
DieterHolvoet →
committed e7363bb8 on 1.x authored by
roderik →
Issue #3418411 by roderik: Move purger settings loading into helper...
-
DieterHolvoet →
committed e7363bb8 on 1.x authored by
roderik →
- Status changed to Fixed
10 months ago 9:25am 1 February 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Thanks for the new release!
The answer is, its' just less confusing to override things in a child purger, at the moment:
- We now have a custom button to purge the whole zone (because the purge module likely will support this, but we can't wait for it). The configuration (zone, key) for that is already in a 'global' config screen that stores a 'regular' settings object, and it's easier to inject those settings directly than duplicate a 'fake config entity' in settings.php
- Our hosting product (the custom part that is based on Lupus Decoupled Drupal → but not open sourced at the moment) has a concept of various "front ends" populated with content from a single Drupal instance. Each front end has their own domain / Bunny zone. I really haven't figured out how to do tag based purging perfectly (or whether it is even desirable to 'route' some tags to a single front end only) so for now I'm just purging all the zones -> I need all the zone IDs -> that's customized stuff.
- (And I want to turn off path/URL based purging for now, on our own 'child class' purger, so I don't need to deal with figuring out what's the zone + base URL for specific paths.)
...so on point 2, I'm now iterating through zones calling parent::invalidateTags() / parent::invalidateAll() while making sure that getPurgerSettings() returns a different zone ID in each iteration. It's slightly wonky code, but at this point still better than just copying this module's code into our setup. I think.
Automatically closed - issue fixed for 2 weeks with no activity.