Following up on issue #3339344 🐛 Fix placing the order twice Fixed , I previously mentioned that:
No need for
loadForUpdatehere since we're not saving the order itself.
LoadUnchangedworks fine.
However, this is not true, we do need to lock the order when we create payments even when we do not modify the order entity itself.
Here's a scenario where loadUnchanged would fail:
onNotify started execution before onReturnonNotify started creating the paymentonReturn started execution and managed to lock the order before onNotify finishedonNotify finished, and the paymentOrderUpdater tried to update the orderpaymentOrderUpdater tried to save the order, the order was still locked by onReturnOrderLockedSaveException was thrownonReturn finishedWith the above scenario, we end up with two payments and an OrderLockedSaveException.
The solution is to use loadForUpdate inside both onReturn and onNotify, and to save the order at the end of onNotify to force the order to get updated, leaving this job to the paymentOrderUpdater, would throw the following exception:
EntityStorageException: Failed to start the session because headers have already been sent
Fixed
1.0
Code
Issue #3418378 by Redwan Jamous: Use loadForUpdate when creating...
Automatically closed - issue fixed for 2 weeks with no activity.