- Issue created by @Ryo Yamashita
- Merge request !2225Add name attributres for the form in SPA (attach/detach interface) β (Merged) created by Ryo Yamashita
- last update
11 months ago 289 pass, 48 fail - Status changed to Needs review
11 months ago 2:05am 31 January 2024 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the fix. The patch reveals the essential problem. I posted my comments. Please make sure of it. Thanks.
- Status changed to Needs work
11 months ago 6:38am 31 January 2024 - last update
11 months ago 289 pass, 48 fail - Status changed to Needs review
11 months ago 8:54am 31 January 2024 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. It looks good. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - Status changed to Needs work
11 months ago 9:34am 31 January 2024 - last update
11 months ago 289 pass, 48 fail - Status changed to RTBC
11 months ago 9:35am 31 January 2024 -
yas β
committed 49edbb5e on 6.x authored by
Ryo Yamashita β
Issue #3418203 by Ryo Yamashita, yas: Add the name attributes for the...
-
yas β
committed 49edbb5e on 6.x authored by
Ryo Yamashita β
- Status changed to Needs work
11 months ago 9:36am 31 January 2024 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Can you create the MR for the 5.x branch? Thanks
error: patch failed: modules/cloud_dashboard/js/index.js:300 error: modules/cloud_dashboard/js/index.js: patch does not apply .../constant/templates/form/openstack/instance.ts | 2 ++ modules/cloud_dashboard/js/index.js | 2 +- .../OpenStack-ATDD-03-05-OperateInstances.feature | 4 +++- 3 files changed, 6 insertions(+), 2 deletions(-) error: patch failed: modules/cloud_dashboard/js/index.js:300 error: modules/cloud_dashboard/js/index.js: patch does not apply On branch 5.x Your branch is up to date with 'origin/5.x'.
- Merge request !2226Add the name attributes for the form in SPA (attach/detach OpenStack interface) β (Merged) created by Ryo Yamashita
- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
11 months ago Waiting for branch to pass - last update
11 months ago 367 pass - Status changed to Needs review
11 months ago 10:09am 31 January 2024 - π―π΅Japan Ryo Yamashita
@yas
I pushed this patch for origin/5.x. Thanks.
- Status changed to RTBC
11 months ago 10:18am 31 January 2024 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.x
and close this issue as Fixed. - last update
11 months ago 367 pass -
yas β
committed 61aa5cec on 5.x authored by
Ryo Yamashita β
Issue #3418203 by Ryo Yamashita, yas: Add the name attributes for the...
-
yas β
committed 61aa5cec on 5.x authored by
Ryo Yamashita β
- Status changed to Fixed
11 months ago 10:18am 31 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.