- Issue created by @nicklasmf
- 🇮🇳India rohit sankhla
Rohit Sankhla → made their first commit to this issue’s fork.
- Status changed to Needs review
11 months ago 12:10pm 31 January 2024 - 🇮🇳India rohit sankhla
Added last method in Drupal/Core/TypedData/Plugin/DataType/ItemList.php, Please review.
- Status changed to Needs work
11 months ago 2:24pm 31 January 2024 - 🇺🇸United States smustgrave
Will need simple test coverage
Change record
And should have a return typehint
- First commit to issue fork.
- 🇮🇳India shalini_jha
I have added return value for last method same as first method.
- Status changed to Needs review
2 months ago 8:08am 9 October 2024 - 🇮🇳India shalini_jha
I have added the Test coverage and Change record → for this. CR is in draft as of now . Moving this for NR.
- 🇺🇸United States smustgrave
Fixed return syntax. Rest appears good and feedback addressed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I searched contrib and there doesn't appear to be any clashing functions and this helps to make the interface more fluent and natural so +1
Committed and pushed b7ce2ab918e to 11.x and c0327e8d90c to 11.1.x. Thanks!
-
alexpott →
committed c0327e8d on 11.1.x
Issue #3418136 by shalini_jha, smustgrave, rohit sankhla: Add last()...
-
alexpott →
committed c0327e8d on 11.1.x
-
alexpott →
committed b7ce2ab9 on 11.x
Issue #3418136 by shalini_jha, smustgrave, rohit sankhla: Add last()...
-
alexpott →
committed b7ce2ab9 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.