security_review.checks.yml fails blt yaml validation

Created on 30 January 2024, 10 months ago
Updated 2 February 2024, 10 months ago

Problem/Motivation

After upgrading from 2.0.1 to 2.0.2 and exporting config, we have a new config file called security_review.checks.yml which has an empty set of curly braces in it. This fails yaml validation.

Steps to reproduce

- upgrade to security_review 2.0.2
- export config
- Run `blt validate:yaml`

Proposed resolution

Do not export this yml file if the fields are null, or actually set the field settings as null in the configuration instead of returning a null set.

πŸ› Bug report
Status

Closed: works as designed

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States loopy1492

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @loopy1492
  • Status changed to Postponed: needs info 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Can you test with 3.0.x branch please

  • πŸ‡ΊπŸ‡ΈUnited States loopy1492

    Thanks for the reply.

    I set drupal/security_review to ^3.0 which upgraded as follows: 2.0.2 => 3.0.0-rc2.

    drush updb didn't seem to indicate any updates that needed to be run.

    I ran drush cr and then drush cex did not indicate any new configuration changes.

    The security_review.checks.yml file is still just

    {  }
    
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    May need to uninstall security review 2.0.x version first. 3.0.x was a complete re-write but currently not much an upgrade path.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    But that is something I fixed in 3.0.x was a single config file vs a dozen.

  • πŸ‡ΊπŸ‡ΈUnited States loopy1492

    When I disable the module and cex, all the config disappears as you might expect. Re-enabling the module has produced only one configuration file as you indicated. 3.x does not seem to have the same issue as 2.x.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Great news!

  • Status changed to Closed: works as designed 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave
Production build 0.71.5 2024