- Issue created by @thomas.lobjoie
- 🇬🇧United Kingdom thomas.lobjoie
I have done a local patch to replace line 144 by:
if (!$this->request->server->has('WINDIR') && !str_contains($this->request->server->has('SERVER_SOFTWARE') ? $this->request->server->get('SERVER_SOFTWARE') : '', 'Win32')) {That fixes the issue for now.
- Merge request !6389Make sure that null is NOT passed as first argument to str_contains. → (Open) created by thomas.lobjoie
- Status changed to Needs work
over 1 year ago 2:38pm 1 February 2024 - 🇩🇪Germany rgpublic Düsseldorf 🇩🇪 🇪🇺
Just for clarity's sake as I don't see this mentioned anywhere, but this happens, for example on CLI (e.g. Cronjobs etc) where
$request->server->get('SERVER_SOFTWARE')obviously isn't available and returns "null". - 🇧🇬Bulgaria pfrenssen Sofia
In the current code base the most common way to detect whether we are running on Windows is
str_starts_with(PHP_OS, 'WIN'). Let's use this for consistency.