- Issue created by @BramDriesen
- last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 9 pass, 23 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago 27 pass, 2 fail - last update
12 months ago PHPLint Failed - last update
12 months ago PHPLint Failed - last update
12 months ago PHPLint Failed - last update
12 months ago 25 pass, 3 fail - last update
12 months ago 25 pass, 3 fail - last update
12 months ago 25 pass, 3 fail - last update
12 months ago 26 pass, 1 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 3 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 25 pass, 2 fail - last update
12 months ago 27 pass, 1 fail - last update
12 months ago 28 pass - Status changed to Needs review
12 months ago 3:28pm 7 February 2024 - Issue was unassigned.
- last update
12 months ago 28 pass - Status changed to Needs work
12 months ago 7:57pm 8 February 2024 - 🇨🇭Switzerland berdir Switzerland
left some comments.
Personally I would definitely recommend to not do that much in a single MR, it's impossible to review. I only scrolled through a bit.
My preferred approach is to just enable tests with required test fixes and everything else in follow-ups, it's just warnings. But it's a bit late for that now, your call.
- last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
11 months ago 28 pass - Status changed to Fixed
11 months ago 3:55pm 15 February 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
After some thought decided to proceed with it and tag a 2.0.x branch.
Drafted a release note for when the first release is tagged on the 2.0.x branch: https://www.drupal.org/node/3421654 →
- 🇨🇭Switzerland berdir Switzerland
Note that using the gitlab UI to merge does by default not use the commit message format that's common in drupal, while having authors mentioned there or not is being discussed, but having that and the issue number allows to generate release notes with https://drupal-mrn.dev/
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I should indeed have squashed it and used the message from the issue here. Normally I always do this, but have forgotten about it this time 😟 Unfortunately I can't git amend and do a force push.
Nice tool by the way!
Automatically closed - issue fixed for 2 weeks with no activity.