Receiving a TypeError in Trash 3.0.1

Created on 30 January 2024, 10 months ago

Updated 16 February 2024, 9 months ago

Problem/Motivation

Since updating to version 3.0.1, some views are encountering an exception that traces back to ViewsQueryAlter::alterQueryForEntityType.

TypeError: Unsupported operand types: string + int in Drupal\trash\ViewsQueryAlter->alterQueryForEntityType() (line 143 of modules/contrib/trash/src/ViewsQueryAlter.php)

Proposed resolution

In 🐛 Trash shouldn't add "or" filter to the first views filter group Fixed , the views query was adjusted so that instead of assuming the WHERE clause should always be added to group 1, it's always made the last group.

However, the array keys for groups can often be strings. In fact, the default value is '1' (1 as a string) -- see \Drupal\views\Plugin\views\filter\FilterPluginBase::defineOptions. So adding 1 to the last group number is subject to a TypeError.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States mediabounds

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mediabounds
Status changed to Needs review 10 months ago2:44am 30 January 2024
Comment 10 months ago →
🇺🇸United States mediabounds
I believe the fix is as simple as casting the group number to an int. Patch attached.
Comment 10 months ago →
System Message

amateescu → committed 2cb2ff47 on 3.x authored by mediabounds →
Issue #3417931 by mediabounds: Receiving a TypeError in Trash 3.0.1
Status changed to Fixed 10 months ago11:14am 2 February 2024
Comment 10 months ago →
🇷🇴Romania amateescu
Committed to 3.x, thanks!
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024