Clean up configuration

Created on 29 January 2024, about 1 year ago
Updated 3 September 2024, 7 months ago

Hi, thanks for your work on the module! I had a suggestion.

Problem/Motivation

At the moment AFAICT the configuration in prevnext.settings:prevnext_enabled_entity_types is redundant - it can be inferred from prevnext_enabled_entity_bundles.

Proposed resolution

Only store and check prevnext.settings:prevnext_enabled_entity_bundles.

Remaining tasks

Do it!

User interface changes

It doesn't require a change in UI.

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom AndyF

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @AndyF
  • Status changed to Closed: outdated 9 months ago
  • 🇫🇮Finland sokru

    Closing this outdated, since on 2.0.x it was only possible to use this module for node entity types. With 3.0.x branch it possible to use for other entity types, eg. taxonomy terms, so having prevnext_enabled_entity_types is required.

  • Status changed to Active 9 months ago
  • 🇬🇧United Kingdom AndyF

    Thanks @sokru! I'm using 3.x, and my config has

    prevnext_enabled_entity_types:
      node: node
    prevnext_enabled_entity_bundles:
      node:
        page: page
    

    There's no need for prevnext_enabled_entity_types because node is already present within prevnext_enabled_entity_bundles if you see what I mean.

    Thanks!

  • 🇩🇪Germany Anybody Porta Westfalica

    @AndyF perhaps you could prepare a MR to remove it and make it clear by code?

  • 🇬🇧United Kingdom AndyF

    Thanks @anybody. I'd be happy to write the code, but there's enough open issues that are more important, I'd rather wait for them to get merged (to avoid both stealing time from them, and possible conflicts).

    Just to make the suggestion crystal clear (hopefully), the following would indicate that prev/next is enabled for the page and article bundle of the node entity type and the tags bundle of the taxonomy_term entity type.

    prevnext_enabled_entity_bundles:
      node:
        page: page
        article: article
      taxonomy_term:
        tags: tags
    

    Thanks

Production build 0.71.5 2024