- Issue created by @vesnag
- Merge request !123417598 automatically rebuild permission on install and uninstall β (Merged) created by vesnag
- Status changed to Fixed
10 months ago 8:47am 31 January 2024 - Status changed to Fixed
10 months ago 1:05pm 2 February 2024 - πΊπΎUruguay gonzalo2683
Hello,
I've been using module and would like to discuss the inclusion of an additional `hook_update_N()` that runs during module updates. I have specific concerns regarding the performance impact this additional process might have, especially on sites with a large number of nodes.
Including an update process that also triggers a permissions rebuild concerns me, as sites which may not need this update are forced to undergo a potentially costly process across a large number of nodes.
My questions and concerns are as follows:
1. What is the justification behind the inclusion of the additional `hook_update_N()`, aside from the install and uninstall processes? I understand there may be valid reasons, but I would like to better understand the context and necessity from the development team's perspective.
2. Has the performance impact of this additional process been considered, especially since the primary updates seem intended for installation and uninstallation scenarios? Recommendations for mitigating impacts on sites that may not directly benefit from this update would be highly appreciated.
Thank you for your time, and I'm open to further discussion on this topic.
Best regards,
- πΊπ¦Ukraine AstonVictor
Hi there,
node grants were added in the 1.3 version of the module.
there are two cases:
1. the module was updated on the site (was previously enabled). in that case, we should use an update hook to rebuild node grants.
2. the module was NOT installed on the site. in that case, we should rebuild node grants via an install hook (an update hook won't be executed/triggered).