Contrib.social

Pass ESLint validations: Form API Example

Open on Drupal.org →
Created on 27 January 2024, about 1 year ago
Updated 16 July 2024, 7 months ago

Problem/Motivation

At 📌 [Meta] Pass Eslint validations Active we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the form_api_example sub-module

Initial errors detected by 27/01/2024

/modules/form_api_example/form_api_example.routing.yml
  16:17  error  Multiple spaces found before ''\Drupal\form_api_example\Controller\Page::description''  no-multi-spaces
  24:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\SimpleForm''               no-multi-spaces
  32:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\InputDemo''                no-multi-spaces
  40:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\StateDemo''                no-multi-spaces
  48:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\ContainerDemo''            no-multi-spaces
  56:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\VerticalTabsDemo''         no-multi-spaces
  64:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\ModalForm''                no-multi-spaces
  73:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\AjaxColorForm''            no-multi-spaces
  81:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\BuildDemo''                no-multi-spaces
  89:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\AjaxAddMore''              no-multi-spaces
  97:11  error  Multiple spaces found before ''\Drupal\form_api_example\Form\AjaxAddRemoveElements''    no-multi-spaces

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: form_api_example
  3. Fix the issues found and make a MR with the fixes.
📌 Task
Status

Fixed

Version

4.0

Component

Form Example

Created by

🇪🇸Spain jlbellido

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024