Contrib.social

Pass ESLint validations: Content Entity Example

Open on Drupal.org →
Created on 27 January 2024, over 1 year ago
Updated 16 July 2024, 10 months ago

Problem/Motivation

At 📌 [Meta] Pass Eslint validations Active we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the content_entity_example sub-module

Initial errors detected by 27/01/2024

modules/content_entity_example/content_entity_example.info.yml
  6:1  error  Expected line before comment  lines-around-comment
modules/content_entity_example/content_entity_example.links.action.yml
  4:3  error  Expected line before comment  lines-around-comment
modules/content_entity_example/content_entity_example.links.menu.yml
  10:14  error  Multiple spaces found before 'content_entity_example.contact_settings'  no-multi-spaces
modules/content_entity_example/content_entity_example.links.task.yml
  19:14  error  Multiple spaces found before 'entity.content_entity_example_contact.delete_form'  no-multi-spaces
  20:14  error  Multiple spaces found before 'entity.content_entity_example_contact.canonical'    no-multi-spaces
modules/content_entity_example/content_entity_example.routing.yml
   8:5  error  Expected line before comment                         lines-around-comment
  13:5  error  Expected line before comment                         lines-around-comment
  20:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  20:3  error  Expected line before comment                         lines-around-comment
  24:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  24:3  error  Expected line before comment                         lines-around-comment
  30:5  error  Expected line before comment                         lines-around-comment
  34:5  error  Expected line before comment                         lines-around-comment
  42:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  42:3  error  Expected line before comment                         lines-around-comment
  46:5  error  Expected line before comment                         lines-around-comment
  53:5  error  Expected line before comment                         lines-around-comment
  57:5  error  Expected line before comment                         lines-around-comment

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: content_entity_example
  3. Fix the issues found and make a MR with the fixes.
📌 Task
Status

Fixed

Version

4.0

Component

Content Entity Example

Created by

🇪🇸Spain jlbellido

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024