- Issue created by @jlbellido
- Merge request !31#3417410: Just replace current .gitlab-ci with the proposed .gitlab-ci.yml template. → (Merged) created by jlbellido
- 🇪🇸Spain jlbellido
I worked on this issue as part of the #ContributionWeekend2024 https://groups.drupal.org/node/537003
- 🇪🇸Spain jlbellido
After a first run with the new gitlab-ci.yml configuration it seems it is working again (https://git.drupalcode.org/issue/examples-3417410/-/pipelines/83155).
However I see a tons of errors on the validation area and the tests, it might be caused by the new configuration or, since the last run was done 10 months ago, it might be the case that they are real issues not related with the configuration. Given this, I think these are the following steps:
- Review if the failing validation checks are caused by a wrong configuration at the new .gitlab-ci.yml file. We need to compare it with the previous configuration.
- It must be done for: eslint, PHPStan & stylelint
- Review the current failing TESTS to see if they are caused by the new configuration or they were failing previously.
- Status changed to Needs review
about 1 year ago 1:10pm 27 January 2024 - 🇪🇸Spain jlbellido
After checking carefully the previous version and the defaults from https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/include... I don't see big differences out of setting 'allow_failure:true' for the phpunit Test job.
Therefore I'm moving this issue to "Needs Review" and opening a new follow-up issue for fixing everything found on the validation checks and current errors on the Tests with the final goal of having this project passing the pipelines successfully with it is current state.
Thanks to @frangarlin ( https://www.drupal.org/u/fjgarlin → ) for his support during the process.
Cheers
- last update
about 1 year ago 187 pass, 11 fail - Status changed to RTBC
about 1 year ago 2:24pm 27 January 2024 - 🇪🇸Spain fjgarlin
I've reviewed what was before (old initial-alpha-phase templates) vs what's now (new recommended templates) and they look good.
The warnings on the different jobs (phpcs, phpstan, phpunit...) were there before, so this is not introducing any errors that weren't there already.Agree that fixes to each job should be tackled on separate issues, so I'm marking this RTBC.
- 🇪🇸Spain jlbellido
I've created 📌 [Meta] Pass Eslint validations Active as a follow up task to have the eslint validation checks passing.
We will need to create more tasks to fix other issues we have currently with the final goal of having everything in green.
- Status changed to Fixed
about 1 year ago 9:30am 31 January 2024 -
valthebald →
committed d4af2e55 on 4.0.x authored by
jlbellido →
#3417410: Just replace current .gitlab-ci with the proposed .gitlab-ci....
-
valthebald →
committed d4af2e55 on 4.0.x authored by
jlbellido →
Automatically closed - issue fixed for 2 weeks with no activity.