Contrib.social

Merge References: Serialization of 'Closure' is not allowed

Open on Drupal.org →
Created on 26 January 2024, 10 months ago
Updated 19 September 2024, about 2 months ago

When trying to merge references, I get the following exception. I tried 4.1.x Dev and 4.2.x Dev.

Exception: Serialization of 'Closure' is not allowed in serialize() (line 14 of core/lib/Drupal/Component/Serialization/PhpSerialize.php).
Drupal\Component\Serialization\PhpSerialize::encode(Array) (Line: 111)
Drupal\Core\KeyValueStore\DatabaseStorageExpirable->doSetWithExpire('form-nAeWq3krW2p2NT2wBfKoGVH3cpY5Hb41Cb2GtnQfVDU', Array, 21600) (Line: 127)
Drupal\Core\KeyValueStore\DatabaseStorageExpirable->setWithExpire('form-nAeWq3krW2p2NT2wBfKoGVH3cpY5Hb41Cb2GtnQfVDU', Array, 21600) (Line: 193)
Drupal\Core\Form\FormCache->setCache('form-nAeWq3krW2p2NT2wBfKoGVH3cpY5Hb41Cb2GtnQfVDU', Array, Object) (Line: 463)
Drupal\Core\Form\FormBuilder->setCache('form-nAeWq3krW2p2NT2wBfKoGVH3cpY5Hb41Cb2GtnQfVDU', Array, Object) (Line: 441)
Drupal\Core\Form\FormBuilder->rebuildForm('mergefilereferences', Object, Array) (Line: 633)
Drupal\Core\Form\FormBuilder->processForm('mergefilereferences', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

The problem is that these closures cannot be serialized. Because the form is a multi-step form, the form array needs to be serialized. That's why there's no errors on the other reports.

    $form['actions']['add'] = [
      '#type' => 'submit',
      '#value' => $this->t('Next step'),
      '#validate' => [
        $this::validateForm(...),
      ],
      '#submit' => [
        $this::submitMergePreConfirm(...),
      ],
    ];

    $form['actions']['submit'] = [
      '#type' => 'submit',
      '#value' => $this->getConfirmText(),
      '#button_type' => 'primary',
      '#submit' => [
        $this::confirmSubmissionHandlerFileMerge(...),
      ],
    ];

Proposed resolution

Use the serializable format for callables:

    $form['actions']['add'] = [
      '#type' => 'submit',
      '#value' => $this->t('Next step'),
      '#validate' => [
        [$this, 'validateForm'],
      ],
      '#submit' => [
        [$this, 'submitMergePreConfirm'],
      ],
    ];

[$this, 'confirmSubmissionHandlerFileMerge'],

🐛 Bug report
Status

Needs work

Version

4.2

Component

User interface

Created by

🇺🇸United States couloir007

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @couloir007
  • Comment 10 months ago →
    solideogloria

    I get this error as well.

  • Comment 10 months ago →
    solideogloria
  • Comment 10 months ago →
    solideogloria
  • Merge request !30Fixes #3417201: The callbacks must be serializable. → (Open) created by solideogloria
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    solideogloria
  • Comment 10 months ago →
    solideogloria
  • Pipeline finished with Success
    10 months ago
    Total: 236s
    #86315
  • Comment 10 months ago →
    solideogloria

    This is a patch that will apply for users on 4.1.0-beta2. The MR patch won't apply unless you're on dev.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-merge-references-exception to hidden.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-merge-references-exception to hidden.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-merge-references-exception to hidden.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-4.1.x to hidden.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-merge-references-exception to active.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    nateB → changed the visibility of the branch 3417201-4.1.x to active.

  • Comment 5 months ago →
    🇺🇸United States nateb Pittsburgh, Pennsylvania, USA

    The patch in #8 works for me using Audit Files 4.1.0-beta2 in Drupal 10.3, PHP 8.3.8, nginx 1.25.4, MySQL 8.3.0

  • Status changed to RTBC 3 months ago
  • Comment 3 months ago →
    solideogloria
  • Pipeline finished with Success
    3 months ago
    Total: 218s
    #261949
  • Status changed to Needs work about 2 months ago
  • Comment about 2 months ago →
    🇬🇧United Kingdom welly

    Not sure if it's directly related to the patch or something else but when I apply the patch and go from "Which file will be the one the others are merged into?" to the confirmation step, I get an error reporting:

    The website encountered an unexpected error. Try again later.InvalidArgumentException: Field field_name is unknown. in Drupal\Core\Entity\ContentEntityBase->getTranslatedField() (line 616 of core/lib/Drupal/Core/Entity/ContentEntityBase.php). Drupal\Core\Entity\ContentEntityBase->get('field_name') (Line: 657)
Drupal\Core\Entity\ContentEntityBase->set('field_name', Array) (Line: 184)
Drupal\auditfiles\Auditor\AuditFilesMergeFileReferences->auditfilesMergeFileReferencesUpdateFileFields(1, 2) (Line: 133)
Drupal\auditfiles\Auditor\AuditFilesMergeFileReferences->listenerMergeFiles(Object, 'Drupal\auditfiles\Event\AuditFilesMergeFilesEvent', Object)
call_user_func(Array, Object, 'Drupal\auditfiles\Event\AuditFilesMergeFilesEvent', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object) (Line: 54)
Drupal\auditfiles\Batch\AuditFilesMergeFileReferencesBatchProcess->dispatch(Array) (Line: 43)
Drupal\auditfiles\Batch\AuditFilesMergeFileReferencesBatchProcess::create(Object, Object, Array) (Line: 296)

    Moving back to "Needs work", unless this is a new/different issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024